Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows Installation Prerequisite #645

Closed
Elkiwa opened this issue Dec 6, 2023 · 3 comments · Fixed by #679
Closed

Update Windows Installation Prerequisite #645

Elkiwa opened this issue Dec 6, 2023 · 3 comments · Fixed by #679
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt
Milestone

Comments

@Elkiwa
Copy link

Elkiwa commented Dec 6, 2023

Environment details

  • OS: Windows 11 x64
  • OS version: 23H2 build 22631.2715
  • node-pty version: 1.0.0

Issue description

While installing with npm under node v21.4.0

npm install -g node-pty

It failed and produced the following messages for 3 .vcxproj files, namely: conpty, conpty_console_list, and pty

npm ERR! C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(504,5): error MSB8040: Spectre-mitigated libraries are required for this project. Install them from the Visual Studio installer (Individual components tab) for any toolsets and architectures being used. Learn more: https://aka.ms/Ofhn4c [<my nodejs path>\bin\node_modules\node-pty\build\conpty.vcxproj]

Luckily, I was able to resolve this with installing MSVC v143 - VS 2022 C++ x64/x86 Spectre-mitigated libs (v14.38-17.8)
image

Thus, the Windows Installation Prerequisite description is quite outdated.

Windows SDK - only the "Desktop C++ Apps" components are needed to be installed

  1. Not only Desktop Development with C++ under "Workloads" tab, but also the corresponding Spectre-mitigated libs under "Individual components" tab are needed
  2. (Optional) https://www.npmjs.com/package/windows-build-tools is not needed for newer Node.js env
npm WARN deprecated windows-build-tools@5.2.2: Node.js now includes build tools for Windows. You probably no longer need this tool. See https://github.com/felixrieseberg/windows-build-tools for details.`
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug debt labels Dec 7, 2023
@rzhao271 rzhao271 added this to the January 2024 milestone Dec 7, 2023
@alphaleadership
Copy link

And node module version throw error

@alphaleadership
Copy link

With lts version

@joaomoreno joaomoreno modified the milestones: January 2024, December / January 2024 Dec 11, 2023
@rzhao271 rzhao271 modified the milestones: December / January 2024, February 2024 Jan 19, 2024
@rzhao271 rzhao271 modified the milestones: February 2024, March 2024 Feb 15, 2024
@eric-gonzalez-tfs
Copy link

Would be great to get this updated in the README. Thanks for posting your solution @Elkiwa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants