Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from GYP to GN #330

Closed
ioquatix opened this issue Jul 6, 2019 · 4 comments
Closed

Migrate from GYP to GN #330

ioquatix opened this issue Jul 6, 2019 · 4 comments

Comments

@ioquatix
Copy link
Contributor

ioquatix commented Jul 6, 2019

We have a ton of issues in script-runner because of node-pty build failing due to node-gyp not being compatible with python3.

e.g. ioquatix/script-runner#103

It looks like the latest version of Electron moved to GN: https://electronjs.org/blog/gn

Maybe it would be a good idea for this project.

@Tyriar
Copy link
Member

Tyriar commented Jul 6, 2019

@deepak1556 has node moved to GN?

@deepak1556
Copy link
Contributor

Nope and they don't plan to do that anytime soon nodejs/node#21410, nodejs/TSC#648 , nodejs/TSC#642

Here is some discussion about getting python3 support in node-gyp nodejs/node-gyp#1337 and there are workarounds mentioned in that thread.

I would recommend not to change the build system, its more technical debt when the adoption rate is nearly zero in the community. But some modules rely on https://github.com/cmake-js/cmake-js which is looked as an alternative.

@ioquatix
Copy link
Contributor Author

ioquatix commented Jul 6, 2019

That all makes sense. I'm sorry I didn't know more. We've just had a hell of a time with gyp and python2.7 especially with Atom.io and it's weird python wrappers.

@Tyriar
Copy link
Member

Tyriar commented Jul 7, 2019

I don't think we should until node has adopted it, #46 is the real problem you're having @ioquatix

@Tyriar Tyriar closed this as completed Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants