Node 10.3: Deprecation notices during compile (still builds)

[technosophos]

Environment details

• OS: macOS
• OS version: 10.13.5
• node-pty version: 0.7.4

Node version is 10.3.0

Issue description

I've been trying to fix some older tools that still use pty.js to use node-pty. But thus far I haven't been able to get node-pty to build:

$ npm install

> [email protected] install /Users/technosophos/Code/ttystudio/node_modules/node-pty
> node scripts/install.js

  CXX(target) Release/obj.target/pty/src/unix/pty.o
../src/unix/pty.cc:154:25: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  v8::String::Utf8Value file(info[0]->ToString());
                        ^
/Users/technosophos/.node-gyp/10.3.0/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly
      marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/technosophos/.node-gyp/10.3.0/include/node/v8config.h:321:29: note: expanded from macro
      'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/unix/pty.cc:165:27: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
    v8::String::Utf8Value arg(argv_->Get(Nan::New<v8::Integer>(i))->ToString());
                          ^
/Users/technosophos/.node-gyp/10.3.0/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly
      marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/technosophos/.node-gyp/10.3.0/include/node/v8config.h:321:29: note: expanded from macro
      'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/unix/pty.cc:176:27: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
    v8::String::Utf8Value pair(env_->Get(Nan::New<v8::Integer>(i))->ToString());
                          ^
/Users/technosophos/.node-gyp/10.3.0/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly
      marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/technosophos/.node-gyp/10.3.0/include/node/v8config.h:321:29: note: expanded from macro
      'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/unix/pty.cc:181:25: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  v8::String::Utf8Value cwd_(info[3]->ToString());
                        ^
/Users/technosophos/.node-gyp/10.3.0/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly
      marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/technosophos/.node-gyp/10.3.0/include/node/v8config.h:321:29: note: expanded from macro
      'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/unix/pty.cc:389:25: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations]
  v8::String::Utf8Value tty_(info[1]->ToString());
                        ^
/Users/technosophos/.node-gyp/10.3.0/include/node/v8.h:2821:5: note: 'Utf8Value' has been explicitly
      marked deprecated here
    V8_DEPRECATED("Use Isolate version",
    ^
/Users/technosophos/.node-gyp/10.3.0/include/node/v8config.h:321:29: note: expanded from macro
      'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
../src/unix/pty.cc:489:21: warning: 'Call' is deprecated [-Wdeprecated-declarations]
  Nan::Callback(cb).Call(Nan::GetCurrentContext()->Global(), 2, argv);
                    ^
../../nan/nan.h:1595:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
6 warnings generated.
  SOLINK_MODULE(target) Release/pty.node

> [email protected] postinstall /Users/technosophos/Code/ttystudio/node_modules/node-pty
> node scripts/post-install.js

added 2 packages from 9 contributors and audited 4 packages in 3.166s
found 0 vulnerabilities
$  node -v 
v10.3.0

[technosophos]

Possibly related to #192 (https://yarnpkg.com/en/package/nan)

[Tyriar]

Did the build fail? That output looks like it would have succeeded since they're just warnings and then the postinstall script ran?

[technosophos]

I will test it out and update this issue accordingly.

[technosophos]

I have confirmed that it is indeed building in spite of the warnings. And it seems to be working as well. I've changed the title accordingly.

[Tyriar]

Merged into #17