Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split node-pty into 2 components #151

Closed
Tyriar opened this issue Oct 27, 2017 · 2 comments
Closed

Split node-pty into 2 components #151

Tyriar opened this issue Oct 27, 2017 · 2 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 27, 2017

I'm proposing we split node-pty into 2 sub-components that can be used independently or together with node-pty. The components would do:

  1. Launch the shell and expose the FD (most of the C++ logic)
  2. Connect to the FD (most of the TS logic)

This will help support:

Note that the node-pty repo and npm package will remain, nothing will change in that respect. The node-pty repo and package will mainly just be glue code between the new sub-components.

@jerch
Copy link
Collaborator

jerch commented Oct 29, 2017

@Tyriar Sounds reasonable. All it needs on C++ side to keep ptys alive under Unix is the valid pty master fd (plus the emulator and buffer states to continue exactly where it stopped). Only the raw pty creation needs to be in component one, the shell could be spawned in TS land. No clue if such a separation would work with winpty.

@Tyriar
Copy link
Member Author

Tyriar commented Dec 21, 2018

No plans to do this any time soon

@Tyriar Tyriar closed this as completed Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants