Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSExportAttribute issues #274

Closed
alexeybut opened this issue Apr 12, 2024 · 2 comments · Fixed by #275
Closed

JSExportAttribute issues #274

alexeybut opened this issue Apr 12, 2024 · 2 comments · Fixed by #275

Comments

@alexeybut
Copy link

@jasongin Thanks for quick #269 fix.
But I have found several issues:

Wrong comment for JSExportAttribute. You didn't add JSExcludeAttribute. Misprint publci.
/// When applied to an assembly, all public types in the assembly are exported, unless excluded
/// by another . When applied to a publci type, all public members
Some issues in IsExported(ISymbol symbol) method.
Please test the code:

[assembly: JSExport]
namespace Aspose.Words
{
    // Raises an exception.
    internal class Class1
    {
    }

    public class Class2
    {
        // Is exported.
        [JSExport(false)]
        public void ExportFalse()
        {
        }
        [JSExport(true)]
        public void ExportTrue()
        {
        }
    }
}
@alexeybut
Copy link
Author

    [JSExport]
    public class Class2
    {
        // Exported
        public string Data { get; set; }
        [JSExport(false)]
        // Exported also
        public string Text { get; set; }
    }

@jasongin
Copy link
Member

Thanks, apparently I did not test thoroughly enough. #275 fixes these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants