[BUG] ABSA sample notebook is referring to non-existent branch name to install pip

[dem108]

Description

https://github.com/microsoft/nlp-recipes/blob/master/examples/sentiment_analysis/absa/absa_azureml.ipynb
is referring to a branch for pip install, which does not exist. Specifically in the Create an Experiment section,

nlp_est = Estimator(source_directory='.',
                   script_params=script_params,
                   compute_target=cluster,
                   environment_variables = {'NLP_ARCHITECT_BE':'CPU'},
                   entry_script='train.py',
                   pip_packages=['git+https://github.com/NervanaSystems/nlp-architect.git@absa',
                                 'spacy==2.1.8']
)

it looks for git+https://github.com/NervanaSystems/nlp-architect.git@absa which does not exist. The git repo has a commit that merges this absa branch into master, so removing the branch name solves the issue. The updated code should be:

nlp_est = Estimator(source_directory='.',
                   script_params=script_params,
                   compute_target=cluster,
                   environment_variables = {'NLP_ARCHITECT_BE':'CPU'},
                   entry_script='train.py',
                   pip_packages=['git+https://github.com/NervanaSystems/nlp-architect.git',
                                 'spacy==2.1.8']
)

and with this updated one the container image build succeeds.

How do we replicate the bug?

Just follow the documentation and it fails without changing anything. According to Azure ML log, it fails at container image build stage, saying absa branch is not found.

Expected behavior (i.e. solution)

The correct git repo to install pip should succeed at container build stage.

Other Comments