Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime platform support detection #92

Closed
scalablecory opened this issue Feb 3, 2020 · 6 comments
Closed

Add runtime platform support detection #92

scalablecory opened this issue Feb 3, 2020 · 6 comments
Labels
Area: API feature request A request for new functionality

Comments

@scalablecory
Copy link

scalablecory commented Feb 3, 2020

It would be useful to have consistent error code(s) for MsQuicOpen to return when the current platform doesn't have a minimum Windows/OpenSSL version, registry for TLS 1.3 isn't enabled, etc.

This would enable users to prompt the end-user, log, etc. with an obvious message indicating what they might do to get support.

@nibanks nibanks added the question Further information is requested label Feb 3, 2020
@nibanks
Copy link
Member

nibanks commented Feb 3, 2020

Not a platform independent error code. Right now, at least one client, that type of error would result in TLS failing to initialize, which would result in a connection shutdown event to the app with whatever status code was returned by the TLS library. For schannel, it would be a fairly specific error code. For openssl, I believe it's just a generic TLS failed error code.

@scalablecory
Copy link
Author

Thanks. Lets make this a feature request then :)

@scalablecory scalablecory changed the title How to check for platform support? Add runtime platform support detection Feb 3, 2020
@scalablecory
Copy link
Author

Related: dotnet/runtime#31689

@nibanks nibanks added enhancement and removed question Further information is requested labels Feb 3, 2020
@nibanks
Copy link
Member

nibanks commented Feb 3, 2020

Ok. Ideally, we'd define a cross-platform QUIC_STATUS for this, and then we need to figure out what TLS error codes need to be mapped to this.

@nibanks
Copy link
Member

nibanks commented Oct 22, 2020

@scalablecory to be clear, we don't have a way to query "Is supported" from our TLS layers. For OpenSSL, it's currently statically linked, so it's always supported. For Schannel, the only way to know is to try it and see if it fails. With that in mind, what exactly is the ask here?

@nibanks
Copy link
Member

nibanks commented Nov 11, 2020

Going to close this with no action, since there isn't really anything we can do here. @scalablecory if you have a specific ask here feel free to reopen with more info.

@nibanks nibanks closed this as completed Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: API feature request A request for new functionality
Projects
None yet
Development

No branches or pull requests

2 participants