Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SQLSRV_ASSERT for checking NULL ptrs #789

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Use SQLSRV_ASSERT for checking NULL ptrs #789

merged 1 commit into from
Jun 6, 2018

Conversation

yitam
Copy link
Contributor

@yitam yitam commented Jun 6, 2018

Use SQLSRV_ASSERT to ensure the subsequent code will not dereference any null pointers (Clang Analyzer reports)


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 74.706% when pulling 44d1bb3 on yitam:moreAsserts into 3585bf5 on Microsoft:dev.

@codecov-io
Copy link

Codecov Report

Merging #789 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #789      +/-   ##
==========================================
+ Coverage   80.06%   80.06%   +<.01%     
==========================================
  Files          25       25              
  Lines        7323     7325       +2     
==========================================
+ Hits         5863     5865       +2     
  Misses       1460     1460
Impacted Files Coverage Δ
.../php-7.1.18-src/ext/sqlsrv/shared/core_results.cpp 74.22% <0%> (+0.04%) ⬆️
...-7.1.18-src/ext/pdo_sqlsrv/shared/core_results.cpp 59.96% <0%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3585bf5...44d1bb3. Read the comment docs.

@yitam yitam merged commit 5a66610 into microsoft:dev Jun 6, 2018
@yitam yitam deleted the moreAsserts branch June 6, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants