Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using reflection on the extension or the functions in the extension result in invalid parameter names. #17

Closed
v-mabarw opened this issue Jul 29, 2014 · 4 comments

Comments

@v-mabarw
Copy link
Contributor

The parameter names to all the functions in the extension (V1.1.428.1) are
quoted ...

[2010/04/30 12:17:20] [C:] [] >c:\php5\php.exe -n -d extension_dir=c:\php5\ext
-d extension="php_sqlsrv_53_nts_vc9.dll" --rf sqlsrv_connect
Function [ internal:sqlsrv function sqlsrv_connect ] {

Patch supplied to fix this.

Regards,

Richard Quadling.

P.S. Re-attached patch and to
http://sqlsrvphp.codeplex.com/SourceControl/PatchList.aspx

Work Item Details

Original CodePlex Issue: Issue 17486
Status: Proposed
Reason Closed: Unassigned
Assigned to: Unassigned
Reported on: Apr 30, 2010 at 11:21 AM
Reported by: RQuadling
Updated on: Jul 17, 2010 at 8:44 PM
Updated by: AshayC

Plaintext Attachments

CodePlex Issue #17486 Plain Text Attachments

@v-mabarw
Copy link
Contributor Author

On 2010-07-14 03:40:01 UTC, icosahedron commented:

Thanks for the bug report. Unfortunately (due to intellectual property restrictions) we are unable to accept patches. We will look into this issue.

@v-mabarw
Copy link
Contributor Author

On 2010-07-14 17:22:54 UTC, RQuadling commented:

The patch I've supplied (and has been deleted it seems) is provided with the best possible license and copyright and IP conditions possible. Basically, it is a string of letters/numbers/symbols which you can look at, interpret and re-use without any care
in the world with regards to where the string of letters/numbers/symbols come from. I'm quite happy to sign a CLA (I've done so for Zend Framework). None of my patches are ground-breaking, earth-shattering, block-busting, etc. I'm simply not that good!. So,
please accept the patches in the spirit that they were supplied with. Free.

Put it this way. Everytime you update your code and I have to patch it again, will simply be another waste of time when the patch will fix it and we can all move on...

Regards,

Richard Quadling.

@v-mabarw
Copy link
Contributor Author

On 2010-07-18 03:44:01 UTC, AshayC commented:

Hi Richard,

We truly appreciate your taking the time to provide a patch. As mentioned above, we are not able to accept contributions at this time. However, we have logged your request (use the ZEND_ARG_INFO correctly in the driver) in our internal issue tracker and will
consider this for a future release.

@yitam
Copy link
Contributor

yitam commented Jan 6, 2017

Already incorporated. Closing the issue

@yitam yitam closed this as completed Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants