Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Many duplicates in minified tsWorker.js leading to large file #4184

Open
2 tasks done
arnoudkooi opened this issue Sep 22, 2023 · 3 comments
Open
2 tasks done
Labels
help wanted Issues identified as good community contribution opportunities

Comments

@arnoudkooi
Copy link

arnoudkooi commented Sep 22, 2023

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Reproduction Steps

  1. Open a compiled version of the file min/vs/language/typescript/tsWorker.min.js CDN Example
  2. Optionally copy the code in a VS Code window
  3. Search for interface CanvasDrawPath {
  4. Note that the definition is found twice
  5. This duplication issue is the case for a lot of code

Code20230923 - 0129

Actual (Problematic) Behavior

The minified version of tsWorker.js is around 4.6 MB I want to use the Monaco editor in a web extension, but this allows a maximum file size of 4 MB

If the code duplication is fixed, that would reduce the filesize enough to get below 4 MB

Expected Behavior

No duplicate code generated during the build

Additional Context

Related Add_ons Linter issue mozilla/addons-linter#3915

@hediet
Copy link
Member

hediet commented Oct 5, 2023

I'm not sure if this is easy to fix - I guess the typescript compiler ships various libraries (like ES3/ES6).

@manjeetsharma0796
Copy link

I think, first analyzing and removing duplicate lines can be done.
Then we can look at the condition, if it solves, then good, otherwise need to look down into deep for solution.

@cyfung1031
Copy link

cyfung1031 commented Apr 30, 2024

The issue is not yet fixed in 0.48.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

4 participants