Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberBox does not set a default AutomationProperties.Name value based on its header. #1854

Closed
YuliKl opened this issue Jan 16, 2020 · 6 comments · Fixed by #1933
Closed
Assignees
Labels
area-NumberBox NumberBox Control spec issue Issue with the feature specification team-Controls Issue for the Controls team

Comments

@YuliKl
Copy link

YuliKl commented Jan 16, 2020

Describe the bug

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Launch XAML Controls Gallery.
  2. Activate Automation Properties from home page.
  3. Navigate to text box present beside Font Size of texts and observe its name property.

Expected behavior

Name Property should be there for text box

Actual behavior

Text box name property missing.

Screenshots

image

Version Info

Gallery version (found on Settings page):

1.2.12.0

Additional context

Copied from internal bug

@marcelwgn
Copy link
Collaborator

I think this is an issue with NumberBox. Setting AutomationProperties.Name explicitly, the edit still has no name set. It seems like the UIA name is only applied to the "container" of the edit.

@YuliKl
Copy link
Author

YuliKl commented Jan 16, 2020

@chingucoding you're right. I remember having this discussion on the original NumberBox page PR. Moving this issue to WinUI.

@YuliKl YuliKl transferred this issue from microsoft/WinUI-Gallery Jan 16, 2020
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jan 16, 2020
@YuliKl YuliKl added the area-NumberBox NumberBox Control label Jan 16, 2020
@StephenLPeters StephenLPeters added team-Controls Issue for the Controls team help wanted Issue ideal for external contributors and removed needs-triage Issue needs to be triaged by the area owners labels Jan 17, 2020
@StephenLPeters StephenLPeters changed the title AutomationProperties page is missing Name Property for Font Size of text box. NumberBox does not set a default AutomationProperties.Name value based on its header. Jan 17, 2020
@StephenLPeters
Copy link
Contributor

@SavoySchuler If there is no header, what should the default automation name be? should the placeholder text be used? Header is an Object, what if it doesn't have a good string equivalent?

@StephenLPeters StephenLPeters added spec issue Issue with the feature specification and removed help wanted Issue ideal for external contributors labels Jan 17, 2020
@ranjeshj
Copy link
Contributor

We could do something similar to

hstring TreeViewNode::GetContentAsString()

@marcelwgn
Copy link
Collaborator

@SavoySchuler If there is no header, what should the default automation name be? should the placeholder text be used? Header is an Object, what if it doesn't have a good string equivalent?

When you look at the sample in the XAML Controls Gallery, the "spinner" has a UIA name, when using AutomationProperties.LabeledBy or AutomationProperties.Name. I think this UIA name should also apply to the "edit".

@robloo
Copy link
Contributor

robloo commented Jul 23, 2020

I don't think this issue was actually fixed. Can someone re-check it? I still see it in version 2.4.2.

Edit: Actually this is related to the header only so perhaps it was fixed. I'm having a related issue in #2951 though.

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jul 23, 2020
@StephenLPeters StephenLPeters added needs-triage Issue needs to be triaged by the area owners and removed needs-triage Issue needs to be triaged by the area owners labels Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NumberBox NumberBox Control spec issue Issue with the feature specification team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants