Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorama is not being installed in Windows even though it is required #256

Open
niander opened this issue Mar 1, 2022 · 0 comments
Open
Assignees

Comments

@niander
Copy link
Member

niander commented Mar 1, 2022

Since version 0.8.3 (which has been removed from public feeds) colorama is only added to the list of requirements if the setup.py is executed in a Windows machine. However, knack is being distributed as a wheel package and setup.py is not executed when installing a wheel package. Therefore, knack is broken when executed from a terminal.

conditional dependency needs to follow PEP 508.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants