Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript - size reduction - move withUrl method in base request adapter #3812

Closed
baywet opened this issue Nov 27, 2023 · 0 comments · Fixed by #3845
Closed

TypeScript - size reduction - move withUrl method in base request adapter #3812

baywet opened this issue Nov 27, 2023 · 0 comments · Fixed by #3845
Assignees
@baywet
Labels
enhancement New feature or request TypeScript Pull requests that update Javascript code WIP
Milestone
Kiota v1.9

Comments

@baywet
Copy link
Member

baywet commented Nov 27, 2023

if we make the base request adapter generic, move the method there, and have the derived request builders pass a reference to their constructor to the base, we should be able to make this method generic and save the weight
@baywet baywet added enhancement New feature or request TypeScript Pull requests that update Javascript code labels Nov 27, 2023
@baywet baywet added this to the Kiota v1.9 milestone Nov 27, 2023
@baywet baywet self-assigned this Nov 27, 2023
@github-project-automation github-project-automation bot moved this to Todo in Kiota Nov 27, 2023
@baywet baywet moved this from Todo to In Progress in Kiota Dec 1, 2023
This was referenced Dec 1, 2023
Merged
Merged
@baywet baywet added the WIP label Dec 1, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kiota Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baywet baywet

Labels
enhancement New feature or request TypeScript Pull requests that update Javascript code WIP
Projects
Kiota
Archived in project
Milestone
Kiota v1.9
Development

Successfully merging a pull request may close this issue.

feature/with raw url hoist microsoft/kiota
1 participant
@baywet