Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enums in Go should not be escaped. #2877

Closed
andrueastman opened this issue Jul 7, 2023 · 0 comments · Fixed by #4136
Closed

Enums in Go should not be escaped. #2877

andrueastman opened this issue Jul 7, 2023 · 0 comments · Fixed by #4136
Assignees
@rkodev
Labels
Go type:bug A broken experience WIP
Milestone
Kiota v1.12

Comments

@andrueastman
Copy link
Member

Enum options in Go need not be escaped by appending the escaped string as they won't cause compilation issues due to the enum suffix as well as the uppercasing. As this change will probably break clients this should be addressed in the next breaking change

https://github.com/microsoftgraph/msgraph-sdk-go/blob/84a68c5f1b78925257f7624d38e4311e134865ad/models/browser_site_merge_type.go#L12
@andrueastman andrueastman added the Go label Jul 7, 2023
@andrueastman andrueastman added this to the Kiota v2.0 milestone Jul 7, 2023
@baywet baywet added the type:bug A broken experience label Jul 7, 2023
@baywet baywet added this to Kiota Jul 7, 2023
@baywet baywet moved this to Todo in Kiota Jul 7, 2023
@rkodev rkodev mentioned this issue Feb 5, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Kiota Feb 5, 2024
@baywet baywet modified the milestones: Kiota v2.0, Kiota v1.12 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkodev rkodev

Labels
Go type:bug A broken experience WIP
Projects
Kiota
Archived in project
Milestone
Kiota v1.12
Development

Successfully merging a pull request may close this issue.

Enums should not be escaped in Go microsoft/kiota
3 participants
@andrueastman @baywet @rkodev