Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce item subcommand for code indexer types #1541

Closed
calebkiage opened this issue May 4, 2022 · 0 comments · Fixed by #1544
Closed

Introduce item subcommand for code indexer types #1541

calebkiage opened this issue May 4, 2022 · 0 comments · Fixed by #1544
Assignees
Labels
CLI Work to support generating CLIs with Kiota type:bug A broken experience

Comments

@calebkiage
Copy link
Contributor

Currently, the API endpoints /users and /users/{user-id} both have their executors under the command mgc users. The difference is that the GET endpoints differ a little. The former generates the command mgc users list while the latter generates the command mgc users get --user-id <userId>. This works fine for most endpoints, but there's a problem with some rare endpoints that have repeated path segments e.g. /sites vs /sites/{site-id}/sites. In this case, there's a conflict with the commands mgc sites list and mgc sites list --site-id <siteId>. Adding the item subcommand for endpoints that have {xxx-id} should fix the issue.
/sites will generate the command mgc sites list while /sites/{site-id}/sites will generate the command mgc sites item list --user-id <userId>

@calebkiage calebkiage added type:bug A broken experience CLI Work to support generating CLIs with Kiota labels May 4, 2022
@calebkiage calebkiage self-assigned this May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Work to support generating CLIs with Kiota type:bug A broken experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants