Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub OpenAPI file fails to generate due to the use of two different parameters as collection indexes. #1535

Closed
darrelmiller opened this issue Apr 28, 2022 · 2 comments · Fixed by #1560
Assignees
Labels
fixed generator Issues or improvements relater to generation capabilities. type:bug A broken experience

Comments

@darrelmiller
Copy link
Member

image
This is valid OpenAPI because all the paths can be resolved unambiguously. However, cannot create two indexers.
We have a few options:

  • For languages without indexers we can change GetById to be GetByParam1 and GetByParam2. However to ensure we are deterministic we need to change this for all cases even if there is only one indexer.
  • For C# we either drop indexers, we find a deterministic way of picking which parameter will use the indexer, or we mash the two parameters into one and split them back apart if necessary.
@baywet baywet self-assigned this Apr 30, 2022
@baywet baywet added type:bug A broken experience generator Issues or improvements relater to generation capabilities. labels Apr 30, 2022
@baywet baywet added this to Kiota May 4, 2022
@baywet baywet moved this to Todo in Kiota May 4, 2022
@baywet baywet moved this from Todo to In Progress in Kiota May 9, 2022
@baywet
Copy link
Member

baywet commented May 9, 2022

@baywet
Copy link
Member

baywet commented May 16, 2022

Thanks for reporting this. It lead to a number of fixes for edge cases in #1560 (see the changelog)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed generator Issues or improvements relater to generation capabilities. type:bug A broken experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants