Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization - get field deserializers doesn't need to be passed the current object in most languages #1490

Closed
Tracked by #25
, #1049
...
baywet opened this issue Apr 4, 2022 · 0 comments · Fixed by #1491
Closed
Tracked by #25
, #1049
...

Optimization - get field deserializers doesn't need to be passed the current object in most languages #1490

baywet opened this issue Apr 4, 2022 · 0 comments · Fixed by #1491
Assignees
@baywet
Labels
Csharp Pull requests that update .net code fixed generator Issues or improvements relater to generation capabilities. Go Java TypeScript Pull requests that update Javascript code
Milestone
Complete Graph AP...

Comments

@baywet
Copy link
Member

baywet commented Apr 4, 2022

The callback for field deserializers see this example doesn't need to be passed the current object.

Effectively this

{"aboutMe", (o,n) => { (o as User).AboutMe = n.GetStringValue(); } },

Can be changed to that

{"aboutMe", (n) => { this.AboutMe = n.GetStringValue(); } },

And the parent method return type can be simplified.

This will contribute to making the generated code smaller as well as the byte code, which has been a challenge for Go and TypeScript.
@baywet baywet added Csharp Pull requests that update .net code TypeScript Pull requests that update Javascript code Go Java generator Issues or improvements relater to generation capabilities. labels Apr 4, 2022
@baywet baywet self-assigned this Apr 4, 2022
@baywet baywet added this to Kiota Apr 4, 2022
@baywet baywet moved this to Todo in Kiota Apr 4, 2022
This was referenced Apr 4, 2022
Merged
Merged
Merged
Merged
@baywet baywet moved this from Todo to In Progress in Kiota Apr 4, 2022
@baywet baywet added the fixed label Apr 4, 2022
This was referenced Apr 4, 2022
Closed
Closed
Open
Closed
Repository owner moved this from In Progress to Done in Kiota Apr 5, 2022
@andrueastman andrueastman mentioned this issue Apr 6, 2022
Merged
@baywet baywet mentioned this issue Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baywet baywet

Labels
Csharp Pull requests that update .net code fixed generator Issues or improvements relater to generation capabilities. Go Java TypeScript Pull requests that update Javascript code
Projects
Kiota
Archived in project
Milestone
Complete Graph API Surface support
Development

Successfully merging a pull request may close this issue.

feature/smaller deserialization microsoft/kiota
1 participant
@baywet