-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KiotaClientFactory doesn't build a httpclient that will work because it is missing auth middleware #270
Comments
Capture notes from our discussion, we could add:
We could consider moving all the authentication considerations out of the request adapter, but that creates two potential issues we designed around by adding it in the request adapter:
@darrelmiller, would you mind putting together a spec for this middleware handler in the SDK design repository please? |
Related microsoft/kiota-http-go#130 |
Transferring issue as part of #238 |
authored microsoftgraph/msgraph-sdk-design#111 to help move this along |
I stumbled upon this issue since I have a custom "Token Refresh" middleware that tries to re-authenticate the request with the refreshed token. I was wondering if it's possible to access the |
currently it's not, but with the new factory we'd be adding with this work, you could at least access it while initializing the middleware, and pass it to your custom middleware implementation. |
https://github.com/microsoft/kiota-http-dotnet/blob/eb76ee893324bd373462e98dfdafeba95762feff/src/KiotaClientFactory.cs#L36
This issue is related to this ADR microsoft/kiota#3941
We need to think about building an AuthHandler middleware that can use our Kiota Auth Providers so that we can have native HttpClient experiences. Otherwise, we can't satisfy this ADR microsoft/kiota#3200
The text was updated successfully, but these errors were encountered: