Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap tavis uri template for std uri template #122

Closed
baywet opened this issue Sep 1, 2023 · 11 comments · Fixed by #123
Closed

swap tavis uri template for std uri template #122

baywet opened this issue Sep 1, 2023 · 11 comments · Fixed by #123
Labels

Comments

@baywet
Copy link
Member

baywet commented Sep 1, 2023

@andreaTP as soon as you think you're ready, please go ahead and submit a PR here. One particularity for dotnet, you need to make sure strong name signing is enabled. If you have questions about that @andrueastman can help you with that

@andreaTP
Copy link
Contributor

andreaTP commented Sep 1, 2023

Never done this before 😊 I think I'll need a little guidance 🙂 .

To my understanding, I need to follow this guide, and add something like this to the csproj file:

<PropertyGroup>
   <SignAssembly>true</SignAssembly>
   <AssemblyOriginatorKeyFile>mykey.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>

is that correct?

@baywet
Copy link
Member Author

baywet commented Sep 1, 2023

that's pretty much the gist of it. @andrueastman can provide additional support if required. (he is located in Nairobi, so he has most likely already finished his week)

@andreaTP
Copy link
Contributor

andreaTP commented Sep 1, 2023

I'll go through this early next week too.

@andreaTP
Copy link
Contributor

andreaTP commented Sep 1, 2023

(trying to find the sn tool for OsX ... )

@baywet
Copy link
Member Author

baywet commented Sep 1, 2023

You might want to try that (never tried it) https://github.com/itn3000/Itn.SnkUtils
I don't have VS installed either on my machine. And internally we have tools to generate those (but I don't think I'm allowed to generate one for a third party)

@baywet
Copy link
Member Author

baywet commented Sep 1, 2023

Also here is some additional guidance that might be helpful.

@andreaTP
Copy link
Contributor

andreaTP commented Sep 1, 2023

thanks!

@andreaTP
Copy link
Contributor

andreaTP commented Sep 4, 2023

Leaving this note as a reference for the future:

I rescued to run sn.exe on a Windows ( windows-latest ) GH Action pipeline ( using tmate for an interactive terminal), the executable is located (at the time of writing) at the path:
/c/Program Files (x86)/Microsoft SDKs/Windows/v10.0A/bin/NETFX 4.8.1 Tools

@andrueastman
Copy link
Member

One particularity for dotnet, you need to make sure strong name signing is enabled. If you have questions about that @andrueastman can help you with that

@andreaTP If it helps you can check out this PR i did some time back to fix the same issue on the Tavis.UrlTemplate package with GH actions pipeline. tavis-software/Tavis.UriTemplates#75

@andreaTP
Copy link
Contributor

andreaTP commented Sep 4, 2023

Thanks @andrueastman for the reference! It helped a lot!
Unfortunately, looks like I still have an issue here: https://github.com/microsoft/kiota-abstractions-dotnet/pull/123/files#diff-a42ff5d9db1c2813144983f2fa3c62170bcc3ea4277d16d3714b3ece41949f83L9

would you mind having a look?

@andrueastman
Copy link
Member

Thanks @andrueastman for the reference! It helped a lot! Unfortunately, looks like I still have an issue here: https://github.com/microsoft/kiota-abstractions-dotnet/pull/123/files#diff-a42ff5d9db1c2813144983f2fa3c62170bcc3ea4277d16d3714b3ece41949f83L9

would you mind having a look?

No worries. Will follow up in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants