rename operational configuration to application configuration #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @technosophos |
technosophos
force-pushed
the
95-rename-app-config
branch
4 times, most recently
from
c575ed6 to
5c796b0
Compare
|
I made a handful of small additional changes to try to disambiguate a few uses of the term "application". But I think there are probably more that we will need to make in future PRs. |
|
@technosophos |
|
I am working on it today. |
Per #95, this renames OperationalConfiguration (and all related terminology) to ApplicationConfiguration (with related terminology). BREAKING CHANGE. Closes #95
technosophos
force-pushed
the
95-rename-app-config
branch
from
5c796b0 to
9d6877f
Compare
yaron2
reviewed
Sep 17, 2019
| }, | ||
| "labels": { | ||
| "type":"object", | ||
| "type": "object", | ||
| "description": "A set of string key/value pairs used as arbitrary labels on this operational configuration.", |
There was a problem hiding this comment.
should probably be application configuration?
| }, | ||
| "annotations": { | ||
| "type":"object", | ||
| "type": "object", | ||
| "description": "A set of string key/value pairs used as arbitrary annotations on this operational configuration.", |
There was a problem hiding this comment.
should probably be application configuration?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #95, this renames OperationalConfiguration (and all related terminology) to ApplicationConfiguration (with related terminology).
BREAKING CHANGE.
Closes #95