Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] Add install option as alternative to ACCEPT_EULA envvar #86

Open
chrisbarrett opened this issue Sep 25, 2022 · 2 comments
Open

Comments

@chrisbarrett
Copy link

chrisbarrett commented Sep 25, 2022

Hello maintainers!

Would you accept a PR, or be interested in introducing, an installation option for this brew so that you could specify an unattended installation via the standard install API, in addition to the environment variable currently supported?

brew install mssql-tools --accept-eula

Use case

A motivating use case is trying to install this brew via nix-darwin with a multi-user-installation1. Any approach I can find to inject this environment variable seems to require a hack somewhere.

{
  homebrew = {
    taps = [{
      name = "microsoft/mssql-release";
      clone_target = "https://github.com/Microsoft/homebrew-mssql-release";
    }];
    extraConfig = ''
      module Utils
        ENV['HOMEBREW_ACCEPT_EULA']='y'
      end
      brew "mssql-tools"
    '';
  };
}

Adding an install option would play better with the standard homebrew API. As a nix-darwin user I could then leverage the normal generated Caskfile:

{
  homebrew = {
    taps = [{
      name = "microsoft/mssql-release";
      clone_target = "https://github.com/Microsoft/homebrew-mssql-release";
    }];
    brews = [{
      name = "mssql-tools";
      args = [ "accept-eula" ];
    }];
  };
}

Thanks for your consideration and cheers for maintaining this brew. :)

Footnotes

  1. A multi-user installation involves farming the actual builds off to build processes that are running under non-login user accounts. See: https://nixos.org/manual/nix/stable/installation/multi-user.html

@v-chojas
Copy link
Contributor

We can consider it for the next release.

@David-Engel
Copy link
Contributor

Feel free to submit a PR and we'll move it forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants