From 2957199154505ce5b884004ed4fe51ca68df985e Mon Sep 17 00:00:00 2001 From: Danny Canter <36526702+dcantah@users.noreply.github.com> Date: Thu, 7 Apr 2022 10:00:29 -0700 Subject: [PATCH] Pin go version for linter to 1.17.x (#1346) Some of the tooling golangci-lint uses doesn't fully support 1.18 yet resulting in a bunch of hard to decode errors. We were using ^1.17.0 as our version listed so we ended up resolving to 1.18 a couple of days ago and finally ran into this. v1.45.0 of golangci-lint has a workaround for this which is disabling some of the problematic linters, but these are some of our most used. This seems like a sane fix for now until the kinks are worked out and things are working on 1.18. Signed-off-by: Daniel Canter --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 34b7a8c7c9..6762da403d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -59,13 +59,14 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-go@v2 with: - go-version: '^1.17.0' + go-version: '1.17.8' - name: golangci-lint uses: golangci/golangci-lint-action@v2 with: version: v1.42.1 # Has fixes for stylecheck configuration https://github.com/golangci/golangci-lint/pull/2017/files args: -v + skip-go-installation: true only-new-issues: true verify-main-vendor: @@ -201,4 +202,4 @@ jobs: - name: Build And Test run: | BASE=./base.tar.gz - make all test + make all test \ No newline at end of file