Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel and vertex shader code does not contain latest Khronos PBR fixes #1

Open
ziriax opened this issue May 26, 2018 · 1 comment
Open

Comments

@ziriax
Copy link

ziriax commented May 26, 2018

First of all many thanks for this sample!

At Wonder Media, we are using DirectX 11 for our custom render and animation engine that uses glTF as model files, and we also made the open source Maya2glTF exporter. It's nice to see an open source glTF viewer based on DX11!

I briefly looked at the code and it seems your shaders are a bit older than the one in the Khronos PBR repos.

Specifically, my pull request that fixed shading non-uniformly scaled models is missing, and also this pull request that fixed a bug where NdotV can be >1.0.

@peted70
Copy link
Contributor

peted70 commented May 26, 2018

Yes, thanks for bringing attention to that. We should at least keep up with any fixes/improvements there and possibly add other shader options moving forwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants