diff --git a/common/changes/office-ui-fabric-react/update-aria-level_2018-08-02-22-33.json b/common/changes/office-ui-fabric-react/update-aria-level_2018-08-02-22-33.json new file mode 100644 index 00000000000000..be8904b0b01d22 --- /dev/null +++ b/common/changes/office-ui-fabric-react/update-aria-level_2018-08-02-22-33.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "Removed unnecessary heading roles, and added aria-level to those requiring them", + "type": "patch" + } + ], + "packageName": "office-ui-fabric-react", + "email": "mgodbolt@microsoft.com" +} \ No newline at end of file diff --git a/packages/office-ui-fabric-react/src/components/ComboBox/ComboBox.tsx b/packages/office-ui-fabric-react/src/components/ComboBox/ComboBox.tsx index 8c4f96a85680bf..c1d06f455a6046 100644 --- a/packages/office-ui-fabric-react/src/components/ComboBox/ComboBox.tsx +++ b/packages/office-ui-fabric-react/src/components/ComboBox/ComboBox.tsx @@ -1119,7 +1119,7 @@ export class ComboBox extends BaseComponent { const { onRenderOption = this._onRenderOptionContent } = this.props; return ( -
+
{onRenderOption(item, this._onRenderOptionContent)}
); diff --git a/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.base.tsx b/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.base.tsx index 5436717a54698d..40576ef788cdc0 100644 --- a/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.base.tsx +++ b/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.base.tsx @@ -302,12 +302,7 @@ export class ContextualMenuBase extends BaseComponent - {title && ( -
- {' '} - {title}{' '} -
- )} + {title &&
{title}
} {items && items.length ? ( +
{ return (
-

+

{title}

- {this.props.topButtonsProps!.map((props, index) => )} + {this.props.topButtonsProps!.map((props, index) => ( + + ))} {(type === DialogType.close || (showCloseButton && type !== DialogType.largeHeader)) && (

implements IP className={css('ms-Panel-headerText', styles.headerText, headerClassName)} id={headerTextId} role="heading" + aria-level={2} > {headerText}