Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts-prettier): escape file names that are being passed to prettier bin via shell #31889

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix(scripts-prettier): escape file names that are being passed to prettier bin via shell #31889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions scripts/prettier/src/prettier-helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,18 @@ function runPrettier(files, config = {}) {

Hotell marked this conversation as resolved.
Show resolved Hide resolved
Hotell marked this conversation as resolved.
Show resolved Hide resolved
mltejera marked this conversation as resolved.
Show resolved Hide resolved
const prettierSupportedFiles = fileIsGlob
? files
: files.filter(file => {
: files.reduce((acc, file) => {
const ext = path.extname(file).replace('.', '');
return prettierSupportedFileExtensions.includes(ext);
});

if (prettierSupportedFileExtensions.includes(ext)) {
// WHY IGNORE IS NEEDED?: prettier removes one of the '\' within replaceValue
// prettier-ignore
const escapedFileName = `"${file.replace(/\$/g, '\\\$')}"`;

acc.push(escapedFileName);
}
return acc;
}, /** @type {string[]} */ ([]));

if (!prettierSupportedFiles.length) {
console.log('prettier: No supported files found');
Expand Down
Loading