Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border CSS getting overridden by consumer #7161

Closed
arkogupta opened this issue Nov 20, 2018 · 2 comments · Fixed by #7211 or #7171
Closed

Border CSS getting overridden by consumer #7161

arkogupta opened this issue Nov 20, 2018 · 2 comments · Fixed by #7211 or #7171

Comments

@arkogupta
Copy link
Contributor

arkogupta commented Nov 20, 2018

Environment Information

  • Package version(s):
  • Browser and OS versions: All

Please provide a reproduction of the bug in a codepen:

  1. Go to a small list with ItemScope enabled : https://msft.spoppe.com/teams/SPGroups/Lists/AmySimpleList/AllItems.aspx
  2. Try doing a drag drop to reorder columns, a border appears around the dragged column header.
  3. Move to a large DocLib like https://msft.spoppe.com/teams/SPGroups/VNextDocLib/Forms/AllItems.aspx and try drag-n-drop. The border still appears.
  4. Now refresh the page and again try drag-n-drop. The border is no longer present.
  5. Go to the earlier small list again and try drag-n-drop. The border is no longer present.

The styles are organized in https://github.com/OfficeDev/office-ui-fabric-react/blob/2ce6c5ac3ccf4e62d4866841317b4aa55b8fb541/packages/office-ui-fabric-react/src/components/DetailsList/DetailsColumn.styles.ts

Actual behavior:

image

The style applied to the class "borderWhileDragging" gets overridden by the css applied to the root class.

Expected behavior:

image

The style applied to the class "borderWhileDragging" gets applied.

Priorities and help requested:

Are you willing to submit a PR to fix? (Yes, No)

Requested priority: (Blocking, High, Normal, Low)
Normal

Products/sites affected: (if applicable)
SharePoint

@arkogupta arkogupta changed the title Border CSS getting overridden by consumer(itemScope) Border CSS getting overridden by consumer Nov 20, 2018
@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #7171, which has now been successfully released as [email protected].:tada:

Handy Links:

@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #7211, which has now been successfully released as [email protected].:tada:

Handy Links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.