docs: Fixing virtualized list example being skipped when tabbing forward #33276
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
george-cz
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Hello, unfortunately this is not a bug in the story, but the combination of current List implementation and tabster, where we're passing a mover down to the list even if there are no focusable elements and tabster steals the focus from the list, trying to focus on the first item inside.
While this workaround works, it does not solve the underlaying problem unfortunately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
When tabbing forward on the
Listexample page, focus would skip over theVirtualized Listexample, but it would not be skipped over when tabbing backwards. This happens because of a weird interaction betweenreact-windowandtabster's mover.New Behavior
This PR disables
tabster's mover logic from theVirtualized Listexample, since it is not needed due to the list having non-interactive elements only. This PR also calls out this behavior in the example's description.Related Issue(s)