-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NormalPeoplePicker required attribute #22528
Comments
I’ve added this to our backlog for review but it’s low on our priority list as we’re likely not going to get to it for a while as we’re currently focused on larger coherence work items and enhancements to our performance. In the meantime, if you want to contribute towards this request, please share your PR and our dev team will review it. |
I've implemented the Since the same errors occur in the same files when I attempt to run those build commands on the current version of the |
@gouttierre Can you help me understand what to do next? I made the code updates and submitted the PR. Two of the automated validations are failing. One issue should not actually be treated as a failure IMO, and I have shared some details in the PR comments explaining why I think that. Despite recent activity from @ling1726, I have yet to receive have any guidance on how to resolve the issues. |
Is there anybody that has contributed to this project before that can help me understand how to proceed? |
@gouttierre I've done everything I can for this. How long does it normally take to get a response from anybody at all? |
hey @tpalacino sorry this fell through the cracks, are you still interested in contributing here? Thanks! |
Yes. I think this is a solid addition |
@micahgodbolt, can you, or someone from coastal, work with @tpalacino on this contribution? @tpalacino this is scheduled for Oct 31- Nov 13th iteration, folks should have time to dig in then. |
@micahgodbolt I am unable to make any sense of why the Sizer step is failing the build on my PR. Can you offer any guidance? |
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Can I please have some communication from a human on this? I have repeatedly tried to get assistance with getting the PR reviewed and approved. |
@tpalacino I've reopened the issue and I'll try to take a look at your PR as soon as possible. |
Awesome. Thanks.
|
@khmakoto any update on this? |
@khmakoto I understand that the primary focus is v9 but this update does a lot to unify the developer experience of the normal people picker and other user input components. It'd be awesome to have this functionality merged. |
@khmakoto I would still very much like to contribute this update to the original pickers if it's possible for anyone to help me out with whatever I was/am missing. I ended up creating a new branch because the old one got too outdated. |
Describe the feature that you would like added
I would like to have a "required" and "onGetErrorMessage" attributes be added
What component or utility would this be added to
NormalPeoplePicker (ideally it would be on the BasePicker so all pickers would have it)
Have you discussed this feature with our team, and if so, who
No
Additional context/screenshots
The expected behavior would be similar to the same attributes of the ComboBox.
The text was updated successfully, but these errors were encountered: