Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-components packages should not depend on react-icons for only class names of regular and filled icons #25598

Closed
GeoffCoxMSFT opened this issue Nov 9, 2022 · 1 comment
Closed

react-components packages should not depend on react-icons for only class names of regular and filled icons #25598

GeoffCoxMSFT opened this issue Nov 9, 2022 · 1 comment
Assignees
@GeoffCoxMSFT
Labels
Area: Icons Fluent UI react-components (v9) Resolution: Soft Close Soft closing inactive issues over a certain period Type: Bug 🐛

Comments

@GeoffCoxMSFT
Copy link
Member

Several components in v9 depend on react-icons for the regular and filled icons class names.
This causes packages to take dependencies on react-icons when the components should be agnostic to a particular icon library used.
While tree-shaking will avoid bundle size bloat, this still causes extra package download for callers not consuming react-icons
@GeoffCoxMSFT GeoffCoxMSFT self-assigned this Nov 9, 2022
@GeoffCoxMSFT GeoffCoxMSFT mentioned this issue Nov 9, 2022
Merged
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Apr 8, 2023
@microsoft microsoft locked as resolved and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@GeoffCoxMSFT GeoffCoxMSFT

Labels
Area: Icons Fluent UI react-components (v9) Resolution: Soft Close Soft closing inactive issues over a certain period Type: Bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GeoffCoxMSFT @msft-fluent-ui-bot