-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Portal Component Not Rendering in Strict Mode #25232
Comments
The problem is strict mode, removing We might still have strict mode bugs |
cc: @GeoffCoxMSFT so we don't lose track. |
Might be related to #24085. It would be great if we could fix the issues together. |
One way of doing this would be to use react internals and key the singleton with the id of the current fiber. This would be possible with https://github.com/facebook/react/blob/e7c5af45ceb8fa2b64d39ec68345254ce9abd65e/packages/react/src/ReactCurrentOwner.js#L23 However, as react states, if we use these internals we cannot expect any official support and they can break at during any release of react |
Library
React Components / v9 (@fluentui/react-components)
System Info
I created a sandbox with side by side menu component, one has inline=true, the other set inline=false;
The one with inline=false, the pop over will not shown after click on the menu.
Here's the code sandbox example https://codesandbox.io/s/great-thompson-gkfe8o?file=/src/index.js
Note: I've also tried other portal components, e.g., combobox, dropdown, etc, it's the same behavior the portal component doesn't render correctly
Are you reporting Accessibility issue?
no
Reproduction
https://codesandbox.io/s/great-thompson-gkfe8o?file=/src/index.js
Bug Description
Actual Behavior
only the menu that has inline=false, the flyout/pop over renders correctly.
Expected Behavior
both menu should be able to open successfully
Logs
No response
Requested priority
Normal
Products/sites affected
No response
Are you willing to submit a PR to fix?
no
Validations
The text was updated successfully, but these errors were encountered: