Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Picker pop up-WCAG 4.1.1, WCAG 4.1.2: Ensures ARIA attributes are allowed for an element's role (button[aria-label="August\ 1\,\ 2020"]). #14464

Closed
Payne-Yan opened this issue Aug 11, 2020 · 9 comments
Assignees
Labels
Area: Accessibility Component: DatePicker Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix Platform: Chrome

Comments

@Payne-Yan
Copy link

Environment Information

  • Package version(s): 7.115.1
  • Browser and OS versions: Chrome Version 84.0.4147.105 (Official Build) (64-bit)

Describe the issue:

Ensures ARIA attributes are allowed for an element's role.

Element path
#button[aria-label="August\ 1,\ 2020"]

Snippet

How to fix
Fix the following

  • ARIA attributes are not allowed: aria-readonly="true", aria-selected="false"

Please provide a reproduction of the issue in a codepen:

Actual behavior:

ARIA attributes are not allowed for an element's role (button[aria-label="August\ 1,\ 2020"]).

Expected behavior:

Ensures ARIA attributes are allowed for an element's role (button[aria-label="August\ 1,\ 2020"]).

Documentation describing expected behavior

@Payne-Yan
Copy link
Author

Repro-Detail
image

@paulgildea paulgildea added Area: Accessibility Component: DatePicker Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix Platform: Chrome and removed Needs: Triage 🔍 labels Aug 11, 2020
@paulgildea
Copy link
Member

@smhigley FYI

@lorejoh12 - I feel like this might be a dupe - not sure though.

@lorejoh12
Copy link
Contributor

We have had a bunch of issues relating to similar discussions about what roles are appropriate for buttons in the grid, while still letting us get all the information across. #13919, #10793

This one is specifically complaining about roles aria-readonly (which is a new issue) and aria-selected (which is same as in 10793, and the fix made to resolve that seems to be what this bug is complaining about)

If we change the role back to gridcell, we'll have the same issues as before with not announcing button semantics. If we remove those two properties, then we're no longer announcing which day is selected. We might be able to get around it by making the aria-labels more verbose, but not sure if that's the best option here.

@Payne-Yan
Copy link
Author

@lorejoh12 Regarding this issue, how are you going to fix it?

@Payne-Yan
Copy link
Author

@khmakoto @paulgildea This issue hasn't been solved on the official website. Would you please solve it first?

@v-ajrai
Copy link

v-ajrai commented Jan 5, 2021

I am also facing similar issue . Do we have any ETA around this??

@Shannon-Ke
Copy link

I'm also facing this issue. I need this fixed for our site to be fully compliant, as I need to send in the fast pass reports. Please provide ETA.
MicrosoftTeams-image (5)

@smhigley
Copy link
Contributor

This is fixed in v8 :). Let me know if you still run into any issues after updating.

Quick note -- there will still be an aria-required-children automated error on the combobox itself, but that's a known false positive that already has an issue logged and fix in progress on the testing tool.

@smhigley
Copy link
Contributor

Closing this as fixed

@microsoft microsoft locked as resolved and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Accessibility Component: DatePicker Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix Platform: Chrome
Projects
None yet
Development

No branches or pull requests

8 participants