-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date Picker pop up-WCAG 4.1.1, WCAG 4.1.2: Ensures ARIA attributes are allowed for an element's role (button[aria-label="August\ 1\,\ 2020"]). #14464
Comments
@smhigley FYI @lorejoh12 - I feel like this might be a dupe - not sure though. |
We have had a bunch of issues relating to similar discussions about what roles are appropriate for buttons in the grid, while still letting us get all the information across. #13919, #10793 This one is specifically complaining about roles aria-readonly (which is a new issue) and aria-selected (which is same as in 10793, and the fix made to resolve that seems to be what this bug is complaining about) If we change the role back to gridcell, we'll have the same issues as before with not announcing button semantics. If we remove those two properties, then we're no longer announcing which day is selected. We might be able to get around it by making the aria-labels more verbose, but not sure if that's the best option here. |
@lorejoh12 Regarding this issue, how are you going to fix it? |
@khmakoto @paulgildea This issue hasn't been solved on the official website. Would you please solve it first? |
I am also facing similar issue . Do we have any ETA around this?? |
This is fixed in v8 :). Let me know if you still run into any issues after updating. Quick note -- there will still be an aria-required-children automated error on the combobox itself, but that's a known false positive that already has an issue logged and fix in progress on the testing tool. |
Closing this as fixed |
Environment Information
Describe the issue:
Ensures ARIA attributes are allowed for an element's role.
Element path
#button[aria-label="August\ 1,\ 2020"]
Snippet
How to fix
Fix the following
Please provide a reproduction of the issue in a codepen:
Actual behavior:
ARIA attributes are not allowed for an element's role (button[aria-label="August\ 1,\ 2020"]).
Expected behavior:
Ensures ARIA attributes are allowed for an element's role (button[aria-label="August\ 1,\ 2020"]).
Documentation describing expected behavior
The text was updated successfully, but these errors were encountered: