Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox with autocomplete = 'on' is narrated as read-only by Windows Narrator #12497

Closed
SarveshNamjoshi opened this issue Apr 1, 2020 · 6 comments

Comments

@SarveshNamjoshi
Copy link

Environment Information
Package version(s): current
Browser and OS versions: Microsoft Edge Version 81.0.416.34 (Official build) beta (64-bit)

Please provide a reproduction of the bug in a codepen:
Code pen : https://codepen.io/Namjoshi/pen/oNXVmNp
repro-steps : 1. Run the codepen in Edge (preferably in Edge chromium)
2. Start windows narrator (with scan mode off)
3. navigate till combobox
4. Observe that narrator is narrating the combobox as read-only

Actual behavior:
For Combobox with autocomplete = 'on', windows narrator is narrating as read-only.

Expected behavior:
Since user is able to type in the combobox, narrator should not narrate the combobox as read-only.

Priorities and help requested:
Requested priority: High

@aneeshack4 aneeshack4 changed the title Combobox with autocompnete = 'on' is narrated as read-only by Windows Narrator Combobox with autocomplete = 'on' is narrated as read-only by Windows Narrator Apr 1, 2020
@aneeshack4
Copy link
Contributor

Hi @SarveshNamjoshi, thanks for reaching out o this. I confirm repro of this behavior:
Uploading image.png…
When autocomplete is on but allowFreeForm is also set to true, it doesn't repro
image. This behavior is explicitly defined in ComboBox.tsx. When freeform is not allowed, readonly is set to true. I believe this is because it's not allowing the user to input options outside of the pre-set ones. So Narrator is correctly reading this out loud as read only. @joschect - correct me if I'm wrong.

@SarveshNamjoshi
Copy link
Author

SarveshNamjoshi commented Apr 2, 2020

@aneeshack4 Thanks for clarifying the behavior.
@joschect
Considering the clarification provided by @aneeshack4, my understanding is:
In our case, since user is typing in the combobox, however the selection is happening from pre-set values and it is not allowing the user to input any options outside the pre-set values, hence as per the default behavior expected from Combobox, the narrator is stating it as read-only.
Could you please confirm on this behavior.

@aneeshack4
Copy link
Contributor

@SarveshNamjoshi Yes confirming that behavior.

@msft-github-bot
Copy link
Contributor

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fabric React!

@betrue-final-final
Copy link
Member

Hey @aneeshack4, @smhigley brought this to my attention. I understand that if you think about how it's built it may make sense for it to be "read-only", but that's a confusing message for someone hearing and using the control. Is there anything we can do?

@smhigley
Copy link
Contributor

smhigley commented May 4, 2020

If it helps, there's work on creating an example of exactly this pattern in the APG: w3c/aria-practices#1026 (code preview: https://raw.githack.com/w3c/aria-practices/select-only-combo/examples/combobox/combobox-select-only.html).

The gist is that rather than use an <input>, the combobox role goes on a <div>, so a readonly attribute is not needed to prevent freeform input

@microsoft microsoft locked as resolved and limited conversation to collaborators Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants