From 27b4a20ec0912274fe25697180a17ff12a9b3c8a Mon Sep 17 00:00:00 2001 From: Vincent Baaij Date: Wed, 3 Jul 2024 22:59:41 +0200 Subject: [PATCH 1/2] AppBar address Aspire regression --- WHATSNEW.md | 3 ++- examples/Demo/Shared/wwwroot/docs/WhatsNew.md | 3 ++- src/Core/Components/AppBar/FluentAppBar.razor.css | 14 +++++++++++++- 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/WHATSNEW.md b/WHATSNEW.md index 86977ac2fb..3e91cbce43 100644 --- a/WHATSNEW.md +++ b/WHATSNEW.md @@ -10,6 +10,8 @@ - [Demo] Fixes link for Time picker in demo projects ([#2246](https://github.com/microsoft/fluentui-blazor/pull/2246)) ### Components +- [Rating] **New component** ([#2258](https://github.com/microsoft/fluentui-blazor/pull/2258)) +- [AppBar] Fix regression with icon accent color - [Autocomplete] Accessibility: Scrolling not working with keyboard ([#2221](https://github.com/microsoft/fluentui-blazor/pull/2221)) - [AutoComplete] Allow focusable Badge dismiss buttons (accessibility) ([#2272](https://github.com/microsoft/fluentui-blazor/pull/2272)) - [Autocomplete] Fix AriaLabel ([#2303](https://github.com/microsoft/fluentui-blazor/pull/2303)) @@ -34,7 +36,6 @@ - [NumberField] Add sbyte type ([#2308](https://github.com/microsoft/fluentui-blazor/pull/2308)) - [Overflow] Add refresh method, add VisibleOnLoad parameter ([#2236](https://github.com/microsoft/fluentui-blazor/pull/2236)) - [ProfileMenu] Fix the initials inner the popup panel ([#2294](https://github.com/microsoft/fluentui-blazor/pull/2294)) -- [Rating] **New component** ([#2258](https://github.com/microsoft/fluentui-blazor/pull/2258)) - [Slider] Fix getting caught in update loop ([#2265](https://github.com/microsoft/fluentui-blazor/pull/2265)) - [Slider] Refactor code after PR #2265 ([#2287](https://github.com/microsoft/fluentui-blazor/pull/2287)) - [TimePicker] Add null check for empty string ([#2245](https://github.com/microsoft/fluentui-blazor/pull/2245)) diff --git a/examples/Demo/Shared/wwwroot/docs/WhatsNew.md b/examples/Demo/Shared/wwwroot/docs/WhatsNew.md index 410c9f0b2e..ee85cfb61c 100644 --- a/examples/Demo/Shared/wwwroot/docs/WhatsNew.md +++ b/examples/Demo/Shared/wwwroot/docs/WhatsNew.md @@ -10,6 +10,8 @@ - [Demo] Fixes link for Time picker in demo projects ([#2246](https://github.com/microsoft/fluentui-blazor/pull/2246)) ### Components +- [Rating] **New component** ([#2258](https://github.com/microsoft/fluentui-blazor/pull/2258)) +- [AppBar] Fix regression with icon accent color - [Autocomplete] Accessibility: Scrolling not working with keyboard ([#2221](https://github.com/microsoft/fluentui-blazor/pull/2221)) - [AutoComplete] Allow focusable Badge dismiss buttons (accessibility) ([#2272](https://github.com/microsoft/fluentui-blazor/pull/2272)) - [Autocomplete] Fix AriaLabel ([#2303](https://github.com/microsoft/fluentui-blazor/pull/2303)) @@ -34,7 +36,6 @@ - [NumberField] Add sbyte type ([#2308](https://github.com/microsoft/fluentui-blazor/pull/2308)) - [Overflow] Add refresh method, add VisibleOnLoad parameter ([#2236](https://github.com/microsoft/fluentui-blazor/pull/2236)) - [ProfileMenu] Fix the initials inner the popup panel ([#2294](https://github.com/microsoft/fluentui-blazor/pull/2294)) -- [Rating] **New component** ([#2258](https://github.com/microsoft/fluentui-blazor/pull/2258)) - [Slider] Fix getting caught in update loop ([#2265](https://github.com/microsoft/fluentui-blazor/pull/2265)) - [Slider] Refactor code after PR #2265 ([#2287](https://github.com/microsoft/fluentui-blazor/pull/2287)) - [TimePicker] Add null check for empty string ([#2245](https://github.com/microsoft/fluentui-blazor/pull/2245)) diff --git a/src/Core/Components/AppBar/FluentAppBar.razor.css b/src/Core/Components/AppBar/FluentAppBar.razor.css index 96db6b1131..029bccac64 100644 --- a/src/Core/Components/AppBar/FluentAppBar.razor.css +++ b/src/Core/Components/AppBar/FluentAppBar.razor.css @@ -63,7 +63,19 @@ ::deep .fluent-appbar-item:hover svg[part="icon-rest"], ::deep .fluent-appbar-item:not(:hover):not(.active) svg[part="icon-active"], -::deep .fluent-appbar-item:not(:hover).active svg[part="icon-rest"], +::deep .fluent-appbar-item:not(:hover) a.active svg[part="icon-rest"], ::deep .fluent-appbar-item[overflow] { display: none; } + +::deep .fluent-appbar-item:not(:hover) .active svg[part="icon-active"] { + display: block; +} + +::deep .fluent-appbar-item.popover:not(:hover) a.active svg[part="icon-active"] { + display: none; +} + +::deep .fluent-appbar-item.popover:not(:hover) a.active svg[part="icon-rest"] { + display: block; +} From bc4d7d46a22d232a0166d8b71e6b8921ff661593 Mon Sep 17 00:00:00 2001 From: Vincent Baaij Date: Wed, 3 Jul 2024 23:02:06 +0200 Subject: [PATCH 2/2] Update WhatsNew --- WHATSNEW.md | 2 +- examples/Demo/Shared/wwwroot/docs/WhatsNew.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/WHATSNEW.md b/WHATSNEW.md index 3e91cbce43..afd01ad031 100644 --- a/WHATSNEW.md +++ b/WHATSNEW.md @@ -11,7 +11,7 @@ ### Components - [Rating] **New component** ([#2258](https://github.com/microsoft/fluentui-blazor/pull/2258)) -- [AppBar] Fix regression with icon accent color +- [AppBar] Fix regression with icon accent color ([#2318](https://github.com/microsoft/fluentui-blazor/pull/2318)) - [Autocomplete] Accessibility: Scrolling not working with keyboard ([#2221](https://github.com/microsoft/fluentui-blazor/pull/2221)) - [AutoComplete] Allow focusable Badge dismiss buttons (accessibility) ([#2272](https://github.com/microsoft/fluentui-blazor/pull/2272)) - [Autocomplete] Fix AriaLabel ([#2303](https://github.com/microsoft/fluentui-blazor/pull/2303)) diff --git a/examples/Demo/Shared/wwwroot/docs/WhatsNew.md b/examples/Demo/Shared/wwwroot/docs/WhatsNew.md index ee85cfb61c..2cb83ca476 100644 --- a/examples/Demo/Shared/wwwroot/docs/WhatsNew.md +++ b/examples/Demo/Shared/wwwroot/docs/WhatsNew.md @@ -11,7 +11,7 @@ ### Components - [Rating] **New component** ([#2258](https://github.com/microsoft/fluentui-blazor/pull/2258)) -- [AppBar] Fix regression with icon accent color +- [AppBar] Fix regression with icon accent color ([#2318](https://github.com/microsoft/fluentui-blazor/pull/2318)) - [Autocomplete] Accessibility: Scrolling not working with keyboard ([#2221](https://github.com/microsoft/fluentui-blazor/pull/2221)) - [AutoComplete] Allow focusable Badge dismiss buttons (accessibility) ([#2272](https://github.com/microsoft/fluentui-blazor/pull/2272)) - [Autocomplete] Fix AriaLabel ([#2303](https://github.com/microsoft/fluentui-blazor/pull/2303))