Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'OK' button rendered outside of panel for Site settings #780

Closed
oneolddev opened this issue Sep 25, 2023 · 4 comments · Fixed by #786
Closed

fix: 'OK' button rendered outside of panel for Site settings #780

oneolddev opened this issue Sep 25, 2023 · 4 comments · Fixed by #786

Comments

@oneolddev
Copy link
Contributor

🐛 Bug Report

Ok button is rendered outside of the dialog boundary when showing the Site Settings for https://www.fluentui-blazor.net/
SiteSettings

💻 Repro or Code Sample

N/A

🤔 Expected Behavior

Button should be rendered within the panel.

😯 Current Behavior

Button is rendered outside of panel.

💁 Possible Solution

Correct css for fluent-dialog-footer class

🔦 Context

🌍 Your Environment

Version: 3.1.0+3cfd4cf29b9230515c8cd9ee8dc2e788dde50d2b - [Powered by .NET 8.0.0-rc.1.23419.4]

@oneolddev oneolddev mentioned this issue Sep 25, 2023
3 tasks
@vnbaaij
Copy link
Collaborator

vnbaaij commented Sep 25, 2023

There are some dialog/padding issues that we will address in a 3.1.1 hotfix. Coming soon...

@joriverm
Copy link
Contributor

@vnbaaij : i was going through the issue tracker to find if there was anything on an issue i was having with dialog height not being correct and the buttons being drawn over my dialog-body.
would this be related or is this a new issue i will need to investigate ?

image

@vnbaaij
Copy link
Collaborator

vnbaaij commented Sep 25, 2023

No, is same issue. Working on that as well.

@joriverm
Copy link
Contributor

alright, good to know! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants