Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: items number badge becomes almost invisible. Also +0 is shown in Overflow component #2248

Closed
darcome opened this issue Jun 24, 2024 · 3 comments
Labels
status:in-progress Work is in progress

Comments

@darcome
Copy link

darcome commented Jun 24, 2024

🐛 Bug Report

The badge containing the number of "invisible" items becomes almost invisible sometimes and it also shows a +0 which I think is useless...

💻 Repro or Code Sample

I have tested it in the demo site:

Badge half visible:
image

Badge almost invisible and therefore "useless":
image

Badge showing +0 which in my opinion is useless too.
image

🤔 Expected Behavior

The badge should always be visible and disappear when it shows +0 because it means there are no overflown items.

😯 Current Behavior

💁 Possible Solution

🔦 Context

🌍 Your Environment

The screenshots come from the demo site.

@microsoft-github-policy-service microsoft-github-policy-service bot added the triage New issue. Needs to be looked at label Jun 24, 2024
@dvoituron
Copy link
Collaborator

Maybe will be fixed with #2236. @vnbaaij can you validate that?

@vnbaaij
Copy link
Collaborator

vnbaaij commented Jun 24, 2024

I have indeed added a 'compensation' for the badge itself in that PR. Will test it some more and will also look at if we can prevent the +0 case

@vnbaaij vnbaaij added status:in-progress Work is in progress and removed triage New issue. Needs to be looked at labels Jun 24, 2024
@vnbaaij
Copy link
Collaborator

vnbaaij commented Jun 24, 2024

Fixed with #2236

@vnbaaij vnbaaij closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:in-progress Work is in progress
Projects
None yet
Development

No branches or pull requests

3 participants