Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Combobox wrong z-index stack order #1188

Closed
dromerolovo opened this issue Dec 22, 2023 · 3 comments · Fixed by #1189
Closed

fix: Combobox wrong z-index stack order #1188

dromerolovo opened this issue Dec 22, 2023 · 3 comments · Fixed by #1189

Comments

@dromerolovo
Copy link
Contributor

dromerolovo commented Dec 22, 2023

When the Height property is not specify in FluentCombobox, some elements are displayed on top of the combobox options list.

image

image

Basically the guitly is this logic:

@if (!String.IsNullOrEmpty(Height)) { <style> @($"#{Id}::part(listbox) {{ max-height: {Height}; z-index: {ZIndex.ComboboxPopup} }}") </style> }

I can make a PR, I just wanted to know if this is intended.

@vnbaaij
Copy link
Collaborator

vnbaaij commented Dec 22, 2023

No, this is not intended. PR is welcome!

@mkgn
Copy link

mkgn commented Jan 22, 2024

I am using this in a Blazor serverside using .Net 8 (Microsoft.FluentUI.AspNetCore.Components v 4.3.1). I have the inside a Below is a minimum syntax that you can just dump to a page and test.

<FluentDataGrid Id="timesheet" Items="workHoursList" TGridItem="WorkHourEntry">
<TemplateColumn>
    <FluentCombobox Placeholder="Select Project" Items="projectList" @bind-Value="@selectedProject" Autocomplete="ComboboxAutocomplete.Both" TOption="string"  Height="200px" />
</TemplateColumn>
</FluentDataGrid>

And this is how it appears

image

If I just set the height of fluent-data-grid-cell then the list appears. Note that I have set the Height to 200px in So I guess the z-index issue still remains.

image

@vnbaaij
Copy link
Collaborator

vnbaaij commented Jan 22, 2024

I am using this in a Blazor serverside using .Net 8 (Microsoft.FluentUI.AspNetCore.Components v 4.3.1). I have the inside a Below is a minimum syntax that you can just dump to a page and test.

This is a different issue. It is a duplicate of #217 (still open) which is tied to an issue in our upstream dependencies. We do not have a good fix available for this.

Some extra food for thought...the FluentDataGrid is primarily meant for displaying data. It is not meant to be an end-all data entry tool. I would suggest to maybe add a button to each row which then leads to an edit form (panel, dialog,...) for each record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants