[ListComponentBase] maintain consistency between SelectedOption and Value #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on and Value when Multiple is false This commit ensures that `SelectedOption` and `Value` consistently reflect each other. When `SelectedOption` is updated, `Value` is adjusted to maintain coherence, and conversely, changes to `Value` are reflected in the corresponding adjustment of `SelectedOption`. This fixes microsoft#983
vnbaaij
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This commit ensures that
SelectedOptionandValueconsistently reflect each other. WhenSelectedOptionis updated,Valueis adjusted to maintain coherence, and conversely, changes toValueare reflected in the corresponding adjustment ofSelectedOption. This fixes #983🎫 Issues
fix: Bind parameter values not updating FluentSelect component #983
👩💻 Reviewer Notes
I added
TOption? _currentSelectedOptionintoListComponentBase, whenSelectedOptionorValuechanges I will update_currentSelectedOptionthen updateSelectedOptionor (and)Value.I handle the case where
SelectedOptionis set but its value is not in the list ofItemsor the case whereItemsis not set (Itemsis null). The case ofValueis set but the value does not match the list ofItemsis also handled, please see it.📑 Test Plan
✅ Checklist
General
⏭ Next Steps
I don't have this