Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Popup: allow to specify mountNode #1177

Closed
layershifter opened this issue Apr 5, 2019 · 1 comment
Closed

Popup: allow to specify mountNode #1177

layershifter opened this issue Apr 5, 2019 · 1 comment
Labels
vsts Paired with ticket in vsts

Comments

@layershifter
Copy link
Member

layershifter commented Apr 5, 2019

Feature Request

Problem description

It's not possible to override container in React.createPortal() inside of Popup: https://github.com/stardust-ui/react/blob/v0.27.0/packages/react/src/components/Popup/Popup.tsx#L234

Proposed solution

Introduce a new prop mountNode/context, ???. It should also handle accessibility and targets in EventListener, too.

@pkumarie2011 pkumarie2011 added the vsts Paired with ticket in vsts label Apr 5, 2019
@layershifter
Copy link
Member Author

Fixed in #1288.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
vsts Paired with ticket in vsts
Projects
None yet
Development

No branches or pull requests

2 participants