Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Package-Toolkit.ps1 to support preview deployment files #891

Merged
merged 6 commits into from
Aug 16, 2024
Merged

Update Package-Toolkit.ps1 to support preview deployment files #891

merged 6 commits into from
Aug 16, 2024

Conversation

flanakin
Copy link
Collaborator

🛠️ Description

People need to be able to deploy things that are in PR. I updated the Package-Toolkit script to support generating a preview version of the template.

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin added the Skill: DevOps GitHub setup and automation label Aug 10, 2024
@flanakin flanakin added this to the 2024-08 - August milestone Aug 10, 2024
@flanakin flanakin requested review from a team, nteyan and helderpinto August 10, 2024 19:12
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review 👀 PR that is ready to be reviewed label Aug 10, 2024
@flanakin flanakin enabled auto-merge (squash) August 10, 2024 19:13
helderpinto
helderpinto previously requested changes Aug 11, 2024
View reviewed changes
Copy link
Member

@helderpinto helderpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once lines 117-118 of Package-Toolkit.ps1 are fixed, this can be merged.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity label Aug 11, 2024
@arthurclares arthurclares removed the Needs: Review 👀 PR that is ready to be reviewed label Aug 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Review 👀 PR that is ready to be reviewed and removed Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity labels Aug 15, 2024
@flanakin flanakin merged commit b5d09bc into dev Aug 16, 2024
1 check passed
@flanakin flanakin deleted the flanakin/dev/deploy-preview branch August 16, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nteyan nteyan Awaiting requested review from nteyan

@helderpinto helderpinto Awaiting requested review from helderpinto

@arthurclares arthurclares Awaiting requested review from arthurclares

Assignees

@flanakin flanakin

@arthurclares arthurclares

Labels
Needs: Review 👀 PR that is ready to be reviewed Skill: DevOps GitHub setup and automation
Projects
None yet
Milestone
2024-09 – September
Development

Successfully merging this pull request may close these issues.
3 participants
@flanakin @helderpinto @arthurclares