-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup search parameters on historical resources #3847
Cleanup search parameters on historical resources #3847
Conversation
Is not it too late? We have prior versions that rely on deleted history. They will not be able to apply if they go in version order. Should we fix prior version instead? |
Good point, it should be in both. That way people who have already updated will still get it, and people who have yet to update get it sooner. |
I don't see how version 73 can be successful with deleting history first. If so, I don't see the need to have special version to do this. We just need to fix 73. |
@@ -0,0 +1 @@ | |||
Execute dbo.DeleteHistory 0,0,0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for this statement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What has happened is that after Schema 76 the IsHistory column was removed from search parameter tables. This column hadn't been being used since v48, but for any customers who had data older than that there could be historical data still in those tables. That data was preventing current data from being returned in search requests because it was filling up the count of resources the search was looking for.
This stored procedure was written as part of v48 to clean up this data, but it was never actually run. This change explicitly runs this stored proc to finally clean up this unneeded data. It does not delete the historical resources, just the search parameters connected to them.
Description
Adds a SQL Schema version that cleans up search parameters on historical resources.
Related issues
Addresses AB#102248
#3846
Testing
FHIR Team Checklist
Semver Change (docs)
Patch