Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Speed up process shutdown #3783

Merged
merged 9 commits into from
Apr 25, 2024
Merged

[Bugfix] Speed up process shutdown #3783

merged 9 commits into from
Apr 25, 2024

Conversation

fhibf
Copy link
Contributor

@fhibf fhibf commented Mar 28, 2024

Description

We noticed the sporadic occurrence of ObjectDisposedReferenceExceptions in our service.
That can be caused by the BackgroundLoop keeping the process longer than the required running.

Adding new exception of type FhirServiceUnavailableException, to indicate the service is no more able to handle requests as it's shutting down.

Related issues

AB#118543

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@fhibf fhibf requested a review from a team as a code owner March 28, 2024 01:47
@fhibf fhibf added Bug Bug bug bug. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Apr 23, 2024
@fhibf fhibf added this to the S139 milestone Apr 23, 2024
@fhibf fhibf merged commit 53aae29 into main Apr 25, 2024
43 checks passed
@fhibf fhibf deleted the user/fhibf/improveShutdown branch April 25, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants