Add support for partial delete success #3781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LTA-Thinking
added
Bug
|
|
||
| namespace Microsoft.Health.Fhir.Core.Exceptions | ||
| { | ||
| public class PartialDeleteSuccessException : MicrosoftHealthException |
There was a problem hiding this comment.
In the context of an exception, I still prefer the terminology of "Incomplete" over "PartialSuccess" 🤔
I'd also argue this is a form of RequestTooCostlyException.
There was a problem hiding this comment.
I like the name better, but I'm hesitant on Request Too Costly. We currently handle those with a 401, and I think 429 is the correct response for this. The request isn't bad, we just are unable to make it work in one pass.
There was a problem hiding this comment.
Switched and changed it to use code 413, request too large.
| public class PartialDeleteSuccessException : MicrosoftHealthException | ||
| { | ||
| public PartialDeleteSuccessException(int numberOfResourceVersionsDeleted) | ||
| : base(Resources.PartialDeleteSuccess.Replace("{0}", numberOfResourceVersionsDeleted.ToString(), StringComparison.Ordinal)) |
There was a problem hiding this comment.
Should this be using string.Format?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
feordin
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If Cosmos DB runs out of RUs while performing a delete operation it will roll back the transaction. This can lead to a situation where it is impossible to delete a resource because it has too much history to delete in one pass. This PR add the ability to optionally support partial delete success. This allows for the service to delete as much of a resource as it can, and leave the rest for a later delete operation. By rerunning the delete operation eventually the resource will be deleted.
Related issues
Addresses AB#118312
Testing
Manually tested. Working on unit tests. E2E tests aren't possible as the scenario is hard to manufacture.
FHIR Team Checklist
Semver Change (docs)
Patch