Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add since to export tests #3625

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Add since to export tests #3625

merged 2 commits into from
Dec 12, 2023

Conversation

LTA-Thinking
Copy link
Collaborator

@LTA-Thinking LTA-Thinking commented Dec 11, 2023 •
edited
Loading

Description

Adds since to export tests to limit data used.

Related issues

Addresses [issue #].

Testing

Existing E2E tests
CI run: https://microsofthealthoss.visualstudio.com/FhirServer/_build/results?buildId=38129&view=results

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@LTA-Thinking LTA-Thinking requested a review from a team as a code owner December 11, 2023 19:14
@LTA-Thinking LTA-Thinking added this to the S130 milestone Dec 11, 2023
@LTA-Thinking LTA-Thinking added Open source This change is only relevant to the OSS code or release. Build labels Dec 11, 2023
mikaelweave
mikaelweave approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@mikaelweave mikaelweave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these tests better! 🦾

@LTA-Thinking
Copy link
Collaborator Author

/azp run

@LTA-Thinking
Copy link
Collaborator Author

\azp run

@LTA-Thinking LTA-Thinking merged commit 4f89a46 into main Dec 12, 2023
34 of 38 checks passed
@LTA-Thinking LTA-Thinking deleted the personal/rojo/fix-export-test-timing branch December 12, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelweave mikaelweave mikaelweave approved these changes

Assignees
No one assigned
Labels
Build Open source This change is only relevant to the OSS code or release.
Projects
None yet
Milestone
S130
Development

Successfully merging this pull request may close these issues.
2 participants
@LTA-Thinking @mikaelweave