Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backward compatibility for historical export SQL changes #3609

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Add backward compatibility for historical export SQL changes #3609

merged 2 commits into from
Dec 1, 2023

Conversation

mikaelweave
Copy link
Contributor

@mikaelweave mikaelweave commented Dec 1, 2023 •
edited
Loading

Description

Added logic to changes stored procedure parameters for GetResourcesByTypeAndSurrogateIdRange. In schema version 68, one parameter was removed and two were added.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mikaelweave mikaelweave requested a review from a team as a code owner December 1, 2023 16:53
@github-actions github-actions bot added the SQL Scripts If SQL scripts are added to the PR label Dec 1, 2023
@mikaelweave mikaelweave added Area-SQL Area related to the SQL Server data provider Bug Bug bug bug. and removed SQL Scripts If SQL scripts are added to the PR labels Dec 1, 2023
@github-actions github-actions bot added SQL Scripts If SQL scripts are added to the PR labels Dec 1, 2023
@mikaelweave mikaelweave added this to the S129 milestone Dec 1, 2023
@mikaelweave mikaelweave self-assigned this Dec 1, 2023
@mikaelweave mikaelweave added Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs and removed SQL Scripts If SQL scripts are added to the PR labels Dec 1, 2023
@github-actions github-actions bot added the SQL Scripts If SQL scripts are added to the PR label Dec 1, 2023
fhibf
fhibf previously approved these changes Dec 1, 2023
View reviewed changes
@mikaelweave mikaelweave merged commit a7ea16e into main Dec 1, 2023
6 of 7 checks passed
@mikaelweave mikaelweave deleted the personal/mikaelw/export-sql-compat=fix branch December 1, 2023 21:36
@mikaelweave mikaelweave mentioned this pull request Dec 4, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PTaladay PTaladay PTaladay approved these changes

@fhibf fhibf fhibf left review comments

@rajithaalurims rajithaalurims Awaiting requested review from rajithaalurims

Assignees

@mikaelweave mikaelweave

Labels
Area-SQL Area related to the SQL Server data provider Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug. Schema Version backward compatible Schema Version unchanged SQL Scripts If SQL scripts are added to the PR
Projects
None yet
Milestone
S129
Development

Successfully merging this pull request may close these issues.
3 participants
@mikaelweave @fhibf @PTaladay