[cherry-pick] Fix two toolbar focus issues #6851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments (microsoft#6830) * Fix bug with nested elements in toolbar click handler * Change files * lint * update change description * slight test improvement * Update change/@microsoft-fast-foundation-2ada25c3-3fb4-48ba-893d-e64d11f7f095.json --------- Co-authored-by: Chris Holt <[email protected]>
* Fix focus issue when clicking on an element in the toolbar * remove describe.only * Change files * Update api-report.md * Update change/@microsoft-fast-foundation-903a969b-3de3-4090-974a-3423344c571c.json --------- Co-authored-by: Chris Holt <[email protected]>
mollykreis
requested review from
EisenbergEffect,
chrisdholt and
nicholasrice
as code owners
chrisdholt
approved these changes
Oct 12, 2023
|
@chrisdholt, do we need to wait for any other reviewers on this cherry-pick PR? |
No, but I'd like to ensure the build passes...not sure why it isn't running though. I'll pull down locally and test and if it doesn't fire we can move it right through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Cherry-picking two fixes for toolbar focus issues:
a7144c6
b78c921
🎫 Issues
This pulls in fixes for #6835 and #6819 into the archives branch
👩💻 Reviewer Notes
N/A
📑 Test Plan
I ran the changes locally and verified the two bugs are indeed fixed in this branch
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps
N/A