Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cannot set the modal value] in [Dialog component] #5731

Closed
YuecongLou opened this issue Mar 11, 2022 · 2 comments
Closed

fix: [cannot set the modal value] in [Dialog component] #5731

YuecongLou opened this issue Mar 11, 2022 · 2 comments
Labels
area:fast-foundation Pertains to fast-foundation bug A bug closed:obsolete No longer valid community:question A question from the community. status:needs-investigation Needs additional investigation

Comments

@YuecongLou
Copy link

🐛 Bug Report

Cannot set the modal to be false by:
modal="false" or modal={false} or ?modal="false" or any other way that i can come up with..

💻 Repro or Code Sample

        class="settings-dialog"
        modal="false"
        @dismiss=${...}
        ${ref("dialogRef")}
        >
        <div class="settings-dialog-header">
                .....
        </div>
    </fluent-dialog>

🤔 Expected Behavior

the modal should be set as false and there should be no overlay element.

😯 Current Behavior

the modal seems still remains true and the overlay element still exists

💁 Possible Solution

🔦 Context

i was hoping to get rid of the overlay element since I was trying to implement a hover to open feature and the overlay would affect the mouseleave function

please ping me @YuecongLou at teams

🌍 Your Environment

  • OS & Device: [e.g. MacOS, iOS, Windows, Linux] on [iPhone 7, PC]
  • Browser [e.g. Microsoft Edge, Google Chrome, Apple Safari, Mozilla FireFox]
  • Version [e.g. 1.8.0]
@YuecongLou YuecongLou added the status:triage New Issue - needs triage label Mar 11, 2022
@EisenbergEffect EisenbergEffect added bug A bug status:needs-investigation Needs additional investigation area:fast-foundation Pertains to fast-foundation community:question A question from the community. and removed status:triage New Issue - needs triage labels Mar 11, 2022
@EisenbergEffect
Copy link
Contributor

I think the modal attribute is a boolean attribute so you either add the attribute or you don't based on whether you want it modal or not. However, I think there may be a bug in the component because if the value is set to true by default, that probably breaks the boolean property. /cc @chrisdholt

@janechu
Copy link
Collaborator

janechu commented May 29, 2024

Unfortunately @microsoft/fast-components has been deprecated for some time.

@janechu janechu closed this as completed May 29, 2024
@janechu janechu added the closed:obsolete No longer valid label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:fast-foundation Pertains to fast-foundation bug A bug closed:obsolete No longer valid community:question A question from the community. status:needs-investigation Needs additional investigation
Projects
None yet
Development

No branches or pull requests

3 participants