Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose real aspect from InlineableHTMLDirective / AspectedHTMLDirective #5683

Closed
nicholasrice opened this issue Mar 1, 2022 · 0 comments · Fixed by #5739
Closed

feat: expose real aspect from InlineableHTMLDirective / AspectedHTMLDirective #5683

nicholasrice opened this issue Mar 1, 2022 · 0 comments · Fixed by #5739
Assignees
@EisenbergEffect
Labels
area:fast-element Pertains to fast-element closed:done Work is finished task A task that's part of a body of feature work.
Milestone
FAST Element 2.0

Comments

@nicholasrice
Copy link
Contributor

SSR infrastructure implements its own regex parsing of attribute values to determine the type of attribute being used in a template (attribute, boolean attribute, property, event).

Let's see if there is a way to make this information available to the directive implementations so that SSR can simply leverage that information instead of having to generate it itself.
@nicholasrice nicholasrice added status:triage New Issue - needs triage area:fast-element Pertains to fast-element labels Mar 1, 2022
@nicholasrice nicholasrice added this to the FASTElement 2.0 milestone Mar 1, 2022
@EisenbergEffect EisenbergEffect added status:planned Work is planned task A task that's part of a body of feature work. and removed status:triage New Issue - needs triage labels Mar 2, 2022
@EisenbergEffect EisenbergEffect moved this from Triage to Backlog in FAST Architecture Roadmap Mar 2, 2022
@EisenbergEffect EisenbergEffect self-assigned this Mar 2, 2022
@EisenbergEffect EisenbergEffect moved this from Backlog to Todo in FAST Architecture Roadmap Mar 7, 2022
@EisenbergEffect EisenbergEffect mentioned this issue Mar 10, 2022
Merged
5 tasks
@EisenbergEffect EisenbergEffect moved this from Todo to In Progress in FAST Architecture Roadmap Mar 14, 2022
@EisenbergEffect EisenbergEffect added status:in-progress Work is in progress and removed status:planned Work is planned labels Mar 14, 2022
@EisenbergEffect EisenbergEffect mentioned this issue Mar 14, 2022
Merged
5 tasks
@EisenbergEffect EisenbergEffect linked a pull request Mar 14, 2022 that will close this issue
feat: aspected html directive exposes metadata #5739
Merged
5 tasks
@EisenbergEffect EisenbergEffect moved this from In Progress to In Review in FAST Architecture Roadmap Mar 14, 2022
@EisenbergEffect EisenbergEffect added closed:done Work is finished and removed status:in-progress Work is in progress labels Mar 15, 2022
Repository owner moved this from In Review to Done in FAST Architecture Roadmap Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EisenbergEffect EisenbergEffect

Labels
area:fast-element Pertains to fast-element closed:done Work is finished task A task that's part of a body of feature work.
Projects
FAST Architecture Roadmap
Archived in project
Milestone
FAST Element 2.0
Development

Successfully merging a pull request may close this issue.

feat: aspected html directive exposes metadata microsoft/fast
2 participants
@EisenbergEffect @nicholasrice