Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fast-element's Array.prototype is being patched twice resulting on duplicate splices #5652

Closed
garuizs opened this issue Feb 24, 2022 · 0 comments · Fixed by #5654, #5656, #5661 or #5662
Closed
Assignees
Labels
area:fast-element Pertains to fast-element bug A bug status:in-progress Work is in progress

Comments

@garuizs
Copy link

garuizs commented Feb 24, 2022

🐛 Bug Report

We have two apps, one hosted inside the other one. Each app has its own build and its own packages, including each their references to fast-element package. In our scenarios, we use the splice() method extensively to update arrays but when doing so, the splices are applied twice, resulting in unexpected results (e.g. removing 2 elements instead of 1).

💻 Repro or Code Sample

🤔 Expected Behavior

😯 Current Behavior

💁 Possible Solution

🔦 Context

🌍 Your Environment

  • OS & Device: Windows 11 PC
  • Browser Microsoft Edge
  • Version
@garuizs garuizs added the status:triage New Issue - needs triage label Feb 24, 2022
@EisenbergEffect EisenbergEffect self-assigned this Feb 24, 2022
@EisenbergEffect EisenbergEffect added bug A bug status:in-progress Work is in progress area:fast-element Pertains to fast-element and removed status:triage New Issue - needs triage labels Feb 24, 2022
@EisenbergEffect EisenbergEffect added this to the FASTElement 2.0 milestone Feb 24, 2022
@EisenbergEffect EisenbergEffect moved this from Triage to In Review in FAST Architecture Roadmap Feb 24, 2022
@EisenbergEffect EisenbergEffect linked a pull request Feb 24, 2022 that will close this issue
5 tasks
Repository owner moved this from In Review to Done in FAST Architecture Roadmap Feb 24, 2022
@EisenbergEffect EisenbergEffect linked a pull request Feb 25, 2022 that will close this issue
5 tasks
@EisenbergEffect EisenbergEffect linked a pull request Feb 25, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment