-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (invalid) validation styling to form components #4082
Comments
The I would suggest changing the border to a neutral color as well as things like the |
I agree this is something we should support in the base components, as well as for unblocking the tooling work. I think from the styling perspective this will be easier to support once the new color work lands because it will make additional palettes like |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hey I would like to add this to our toolkit. But it would definitely be better if it can be upstream. Is there some pointers on the API design to implement this feature - presumably linked to that issue too #2442? |
That would be great. I would still love to see this come in as a feature. In general we keep the API consistent with any existing public API, like https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Constraint_validation#validation-related_attributes. I suspect there is probably a tie-in with the I'm happy to help with design implications if you run into anything. For context, we've considered adding 'error' and 'success' base colors and palettes to support this. Now that we'd be officially supporting this in the foundation it seems time to add them. Of course, with the fast-components updates, that belongs in the future color and design package I've drafted in #5895 but will be writing up in proposal form soon. |
I think we'll want to move this over to the CLI repository where the components will be living. We can certainly look to take up the feature request there. |
Unfortunately |
What feature are you requesting?
Adding validation styles when the form component is invalid.
What would be the benefit of adding this feature?
Uniform styling of validation errors.
What solution would be ideal for you?
using an attribute
aria-invalid
What alternatives have you considered?
Adding custom styling
Attach screenshots or images add detail to your request:
Some examples:
The text was updated successfully, but these errors were encountered: