Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api-extractor exception from @microsoft/fast-foundation #3317

Closed
nicholasrice opened this issue Jun 16, 2020 · 3 comments
Closed

Remove api-extractor exception from @microsoft/fast-foundation #3317

nicholasrice opened this issue Jun 16, 2020 · 3 comments
Labels
area:dev-ops Pertains to build, CI, and other dev-ops work chore Maintenance or non-code work closed:done Work is finished status:blocked Any issue blocked by another

Comments

@nicholasrice
Copy link
Contributor

#3316 implements a change to packages/web-components/fast-foundation/api-extractor.json that instructs the ae-different-release-tags rule to not fail in CI. This is due to an issue in api-documenter not being able to differentiate exports of the same name. Several components implement a mixin pattern where naming an interface the same as a class is required.

When the api-documenter issue is fixed we can revert the change to our api-extractor.json and update the release-tag reference for all relevant exports.

@triage-new-issues triage-new-issues bot added the status:triage New Issue - needs triage label Jun 16, 2020
@nicholasrice nicholasrice added feature A new feature status:blocked Any issue blocked by another labels Jun 16, 2020
@triage-new-issues triage-new-issues bot removed the status:triage New Issue - needs triage label Jun 16, 2020
@EisenbergEffect EisenbergEffect added area:dev-ops Pertains to build, CI, and other dev-ops work chore Maintenance or non-code work and removed feature A new feature labels Jul 20, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Dec 25, 2020
@Ibrahimmaga
Copy link
Contributor

api-extractor.json was causing problem in windows environment when I was messing around with prettier:diff to solve windows os validation. This doesn't seems a problem any longer since windows validation is working. But if someone get any exception error, let me know then we will remove the exception.

@stale stale bot removed the warning:stale No recent activity within a reasonable amount of time label Jan 11, 2021
@EisenbergEffect EisenbergEffect removed this from the Release 2021-02 milestone Feb 1, 2021
@Ibrahimmaga
Copy link
Contributor

closes #4281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-ops Pertains to build, CI, and other dev-ops work chore Maintenance or non-code work closed:done Work is finished status:blocked Any issue blocked by another
Projects
None yet
Development

No branches or pull requests

3 participants